-
Notifications
You must be signed in to change notification settings - Fork 57
Fix block validation errors #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
655bb18 to
7fe3a47
Compare
| <PROJECT_ROOT>/node_modules/fbjs/.* | ||
| <PROJECT_ROOT>/node_modules/graphql/.* | ||
| <PROJECT_ROOT>/node_modules/prettier/.* | ||
| <PROJECT_ROOT>/node_modules/jsx-to-string/.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like those are necessary sometimes, let's just add those
pinarol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Tested with both with iOS example app and with this post on WP-iOS side, it used to display lots of validation errors now it doesn't.
267b43f to
42fd5c4
Compare
…t of metro-react-native-babel-preset
42fd5c4 to
734b021
Compare
Requires WordPress/gutenberg#12552
Fix "Block validation failed for
core/paragraph... " errors when trying the demo post content from gutenberg.For this we remove the babel transform
react-native-classname-to-stylewhich would cause unexpected result when saving blocks and thus validation errors.This PR also removes some unused dependencies and others that are already provided by
@wordpress/babel-preset-default.Lastly, it updates the
initial-html.jsand appends the whole content of the gutenberg demo post which can be found here https://wordpress.org/gutenberg/